Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relations not handled for folderish content #118

Closed
pbauer opened this issue Feb 6, 2024 · 0 comments · Fixed by #119
Closed

Relations not handled for folderish content #118

pbauer opened this issue Feb 6, 2024 · 0 comments · Fixed by #119

Comments

@pbauer
Copy link
Sponsor Member

pbauer commented Feb 6, 2024

When creating a working copy of folderish content the RelationValues are simply copied from the baseline to the copy. This reuses the same object for baseline and copy and since __parent__ and from_object of the RelavionValue is set each time the source is changed and the only object you can change is the copy the relation from the baseline is essentially removed from the relation catalog. If the view uses the relation-catalog (e.g by using plone.api.relation) to display outgoing relations all objects that are being worked on look like it do not have any.

Instead the working copy needs to get freshly created RelationValue items.
pbauer added a commit that referenced this issue Feb 6, 2024
@pbauer
Handle relation-fields for working copies of folderish content (#118)
d97ca8e
@pbauer pbauer mentioned this issue Feb 6, 2024
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Feb 19, 2024
@jensens
[fc] Repository: plone.app.iterate
52d0d31 
Branch: refs/heads/master
Date: 2024-02-06T12:04:09+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@d97ca8e

Handle relation-fields for working copies of folderish content (plone/plone.app.iterate#118)

Files changed:
M plone/app/iterate/dexterity/copier.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-06T12:06:32+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@86fa7f5

add changenote and remove dead archetypes code

Files changed:
A news/118.bugfix
M plone/app/iterate/base.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-06T12:08:33+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@07e7097

add missing dependency

Files changed:
M setup.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-12T16:58:06+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@018265e

add test for relationfields

Files changed:
M plone/app/iterate/tests/test_containers.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-19T10:56:15+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.iterate@975b5d4

Merge pull request #119 from plone/handle_relations

Handle relation-fields for working copies of folderish content

Files changed:
A news/118.bugfix
M plone/app/iterate/base.py
M plone/app/iterate/dexterity/copier.py
M plone/app/iterate/tests/test_containers.py
M setup.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Feb 19, 2024
@jensens
[fc] Repository: plone.app.iterate
720e26a 
Branch: refs/heads/master
Date: 2024-02-06T12:04:09+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@d97ca8e

Handle relation-fields for working copies of folderish content (plone/plone.app.iterate#118)

Files changed:
M plone/app/iterate/dexterity/copier.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-06T12:06:32+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@86fa7f5

add changenote and remove dead archetypes code

Files changed:
A news/118.bugfix
M plone/app/iterate/base.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-06T12:08:33+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@07e7097

add missing dependency

Files changed:
M setup.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-12T16:58:06+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.iterate@018265e

add test for relationfields

Files changed:
M plone/app/iterate/tests/test_containers.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2024-02-19T10:56:15+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.iterate@975b5d4

Merge pull request #119 from plone/handle_relations

Handle relation-fields for working copies of folderish content

Files changed:
A news/118.bugfix
M plone/app/iterate/base.py
M plone/app/iterate/dexterity/copier.py
M plone/app/iterate/tests/test_containers.py
M setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle relation-fields for working copies of folderish content plone/plone.app.iterate
1 participant
@pbauer