Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Commit

Permalink
Merge branch 'refs/heads/1.4'
Browse files Browse the repository at this point in the history
Conflicts:
	CHANGES.rst
  • Loading branch information
esteele committed Aug 31, 2012
2 parents 7432214 + c0235fd commit fadda59
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
8 changes: 6 additions & 2 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
Changelog
=========

1.5dev - unreleased
-------------------
1.5 - (unreleased)
------------------

- Add translatable string for close box. This and the following change by
giacomos fix http://dev.plone.org/ticket/12122.
[fulviocasali]

- Use link instead of @import for css resources. This improves speed, since it
better uses parallel downloads. See: "don’t use @import" by Steve Souders.
Expand Down
13 changes: 11 additions & 2 deletions plone/app/jquerytools/browser/overlayhelpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*****************/

/*jslint browser: true, onevar: true, undef: true, nomen: true, eqeqeq: true, plusplus: true, bitwise: true, newcap: true, immed: true, regexp: false, white:true */
/*global jQuery, ajax_noresponse_message, window */
/*global jQuery, ajax_noresponse_message, close_box_message, window */

// Name space object for pipbox
var pb = {spinner: {}, overlay_counter: 1};
Expand Down Expand Up @@ -193,14 +193,23 @@ jQuery(function ($) {
******/
pb.create_content_div = function (pbo, trigger) {
var content,
close_message,
top,
pbw = pbo.width;

if (typeof(close_box_message) === 'undefined') {
close_message = 'Close this box.';
} else {
close_message = close_box_message;
}

content = $('' +
'<div id="' + pbo.nt +
'" class="overlay overlay-' + pbo.subtype +
' ' + (pbo.cssclass || '') +
'"><div class="close"><a href="#" title="Close this box">Close</a></div></div>');
'"><div class="close"><a href="#" title="Close this box">' +
close_message +
'</a></div></div>');

content.data('pbo', pbo);

Expand Down

0 comments on commit fadda59

Please sign in to comment.