Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content provider abuse #188

Closed
ale-rt opened this issue Mar 4, 2019 · 0 comments
Closed

Fix content provider abuse #188

ale-rt opened this issue Mar 4, 2019 · 0 comments
Labels
05 type: question

Comments

@ale-rt
Copy link
Member

ale-rt commented Mar 4, 2019 •
edited

The plone.global_sections viewlet (which is a content provider) uses since plone/Products.CMFPlone#2516 is merged another contentprovider (plone.navtree) to render the navigation.

IMHO this is not necessary.

I would like to remove the plone.navtree as soon as possible.
ale-rt added a commit that referenced this issue Mar 4, 2019
@ale-rt
Remove the plone.navtree content provider
06d13ca 
Remove the ``plone.navtree`` content provider that was introduced in the context of the Navigation PLIP (plone/Products.CMFPlone#2516)

Fixes #188
ale-rt added a commit that referenced this issue Mar 4, 2019
@ale-rt
Remove the plone.navtree content provider
a5f84a6 
Remove the ``plone.navtree`` content provider that was introduced in the context of the Navigation PLIP (plone/Products.CMFPlone#2516)
The logic has been moved to the viewlet that was invoking it.

Fixes #188
@ale-rt ale-rt mentioned this issue Mar 4, 2019
Merged
talarias pushed a commit that referenced this issue Dec 9, 2021
@vincentfretin
Merge pull request #188 from plone/revert-fixed-button-width
1537e8f 
Revert button fixed width in actions control panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
05 type: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ale-rt