Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reference to default img #190

Merged
merged 1 commit into from Apr 28, 2016
Merged

fix reference to default img #190

merged 1 commit into from Apr 28, 2016

Conversation

vangheem
Copy link
Member

No description provided.

@vangheem
Copy link
Member Author

I didn't really change anything so this shouldn't be failing.

@thet
Copy link
Member

thet commented Apr 26, 2016

possibly it's due to some changes @jensens and I were making recently. all of them were passing on their own test suites, but at some point I recognized that mosaic isn't working any more. I'm going to isolate that problem from tomorrow on...

plone/plone.tiles#7
plone/plone.app.blocks#34
plone/plone.subrequest#9
plone/plone.app.standardtiles#29

@vangheem vangheem force-pushed the fix-default-preview branch 2 times, most recently from 0fee55a to 3f466ec Compare April 27, 2016 20:32
@jensens
Copy link
Sponsor Member

jensens commented Apr 28, 2016

Both, master and this branch, are running local using the exact same steps as in .travis.yml w/o any failures. This is valid for the tests and also for pybot. Latter fails on Travis CI.

@datakurre
Copy link
Member

So, sounds like the current failures can probably be attributed to Selenium / Firefox differences. Also phantomjs should be working nowadays, so I'll try that on a separate branch.

@datakurre
Copy link
Member

Well, I seem to be able to reproduce this (the issue in current master) locally.

@jensens
Copy link
Sponsor Member

jensens commented Apr 28, 2016

I just found plone.subrequest is needed from sources, also timing problems in robot. pushed it to master.

@thet
Copy link
Member

thet commented Apr 28, 2016

@datakurre can we hook Page should contain and all those directives to "Wait until" the elements are available? I guess we could just wait everywhere instead, where we otherwise use directives which check for something being available immediately.
That could solve all of our timing problems.

@datakurre
Copy link
Member

@thet Please do. It adds longer timeout when tests do really fail, but no other harm. Probably drops more false positives than cause real harm.

@jensens
Copy link
Sponsor Member

jensens commented Apr 28, 2016

after fixing the tests there is a problem left, see #194

@datakurre datakurre merged commit e1a0ce1 into master Apr 28, 2016
@datakurre datakurre deleted the fix-default-preview branch April 28, 2016 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants