Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting querystring vocabs in context #137

Merged
merged 3 commits into from Sep 21, 2023
Merged

Conversation

davisagli
Copy link
Sponsor Member

Add a way to get querystring info with vocabularies fetched in a specific context.

(This doesn't change anything on its own. I'm going to make a related PR in plone.restapi which uses it.)

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@davisagli
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

1 similar comment
@davisagli
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit c2e7f3a into master Sep 21, 2023
12 checks passed
@davisagli davisagli deleted the contextual-vocabs branch September 21, 2023 14:40
@tisto
Copy link
Sponsor Member

tisto commented Sep 21, 2023

@davisagli do you want me to make a release or will you take care of it?

@davisagli
Copy link
Sponsor Member Author

@tisto Go ahead if you want, otherwise I can

@tisto
Copy link
Sponsor Member

tisto commented Sep 21, 2023

@davisagli I am busy with plone.rest(api) right now, so feel free to go ahead. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants