New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsedquery customizable #18

Merged
merged 16 commits into from Apr 3, 2014

Conversation

Projects
None yet
6 participants
@keul
Member

keul commented Nov 1, 2013

This pull request is quite complex, so before looking at the code there's something to explain.

First of all: the actual plone.app.querystring seems a lot complex if compared to old collections.
The idea that forced me to branch is about creating a new collection criteria that is not strictly related to an existing catalog index. This is totally unsupported right now by collections and p.a.querystring.

So: this branch will make possible to define one or more "parsed query index modifiers" by defining named utilities.
Those utilities can:

  • modify the query
  • modify the used index

Apart my final motivation (look at https://github.com/keul/collective.typecriterion) this change make possible to translate the fix for Subject index that now live in p.a.querystring code (that is quite ugly) to something more clean (the Subject index modifier is part of the branch).

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Jan 29, 2014

TESTS FAILED
Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=66e36efc7d3b40e4bf169be5f2dfd471
plone-5.0-python-2.7 [FAILURE]
plone-4.2-python-2.6 [FAILURE]
plone-4.2-python-2.7 [FAILURE]
plone-4.3-python-2.6 [FAILURE]
plone-4.3-python-2.7 [FAILURE]

mister-roboto commented on 4d04e40 Jan 29, 2014

TESTS FAILED
Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=66e36efc7d3b40e4bf169be5f2dfd471
plone-5.0-python-2.7 [FAILURE]
plone-4.2-python-2.6 [FAILURE]
plone-4.2-python-2.7 [FAILURE]
plone-4.3-python-2.6 [FAILURE]
plone-4.3-python-2.7 [FAILURE]

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Mar 30, 2014

TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=4c87bffcbcb54e5890c531b3691f2b1a
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs

mister-roboto commented on 6e8e0ee Mar 30, 2014

TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=4c87bffcbcb54e5890c531b3691f2b1a
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs

@jensens

This comment has been minimized.

Show comment
Hide comment
@jensens

jensens Apr 1, 2014

Member

This one is really useful. Can you please merge master so its able to merge?

Member

jensens commented Apr 1, 2014

This one is really useful. Can you please merge master so its able to merge?

@keul

This comment has been minimized.

Show comment
Hide comment
@keul

keul Apr 2, 2014

Member

@jensens Done!

Member

keul commented Apr 2, 2014

@jensens Done!

@keul

This comment has been minimized.

Show comment
Hide comment
@keul

keul Apr 3, 2014

Member

Any news? I'd really like to see this merged, this stuff will also simplify some solr/collective.solr integration we have :)

Member

keul commented Apr 3, 2014

Any news? I'd really like to see this merged, this stuff will also simplify some solr/collective.solr integration we have :)

@jensens jensens merged commit 94e4706 into plone:master Apr 3, 2014

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on c0c3119 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 7e2087d Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 9b1779a Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 7ee72d7 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on c3a4c20 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on d246097 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on d9a62fe Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on d461fa2 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 5b4b424 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on e7747f9 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 164e15d Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 2bcdc21 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@mister-roboto

This comment has been minimized.

Show comment
Hide comment
@mister-roboto

mister-roboto Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

mister-roboto commented on 94e4706 Apr 3, 2014

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=6e129c64cc284d03ba9d4a55a25b2dea
[SUCCESS] kgs-plone.app.querystring-plone-5.0-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-plone.app.querystring-plone-4.3-python-2.6 kgs
[FAILURE] kgs-plone.app.querystring-plone-4.3-python-2.7 kgs

@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Apr 3, 2014

Member

🍻

Member

davisagli commented Apr 3, 2014

🍻

@jensens

This comment has been minimized.

Show comment
Hide comment
@jensens

jensens Apr 3, 2014

Member

so its used in 4.3 too. lets see. difficult to hold all ends in the hand. sigh.

Member

jensens commented Apr 3, 2014

so its used in 4.3 too. lets see. difficult to hold all ends in the hand. sigh.

@keul

This comment has been minimized.

Show comment
Hide comment
@keul

keul Apr 4, 2014

Member

Honestly I don't always understand the mr.roboto/jenkins reports. There are problems with the new code?

Member

keul commented Apr 4, 2014

Honestly I don't always understand the mr.roboto/jenkins reports. There are problems with the new code?

@tisto

This comment has been minimized.

Show comment
Hide comment
@tisto

tisto Apr 4, 2014

Member

@keul Sorry. Those KGS jobs should have been removed long time ago since they almost always somehow fail. Unfortunately @bloodbare is really busy these days and he is currently the only person who can remove those misleading reports.

Member

tisto commented Apr 4, 2014

@keul Sorry. Those KGS jobs should have been removed long time ago since they almost always somehow fail. Unfortunately @bloodbare is really busy these days and he is currently the only person who can remove those misleading reports.

@keul keul deleted the keul:expandible-parsedquery branch Apr 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment