Make parsedquery customizable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to add changes.
Implement multipath queries.
|
This one is really useful. Can you please merge master so its able to merge? |
|
@jensens Done! |
|
Any news? I'd really like to see this merged, this stuff will also simplify some solr/collective.solr integration we have :) |
|
🍻 |
|
so its used in 4.3 too. lets see. difficult to hold all ends in the hand. sigh. |
|
Honestly I don't always understand the mr.roboto/jenkins reports. There are problems with the new code? |
|
@keul Sorry. Those KGS jobs should have been removed long time ago since they almost always somehow fail. Unfortunately @bloodbare is really busy these days and he is currently the only person who can remove those misleading reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is quite complex, so before looking at the code there's something to explain.
First of all: the actual plone.app.querystring seems a lot complex if compared to old collections.
The idea that forced me to branch is about creating a new collection criteria that is not strictly related to an existing catalog index. This is totally unsupported right now by collections and p.a.querystring.
So: this branch will make possible to define one or more "parsed query index modifiers" by defining named utilities.
Those utilities can:
Apart my final motivation (look at https://github.com/keul/collective.typecriterion) this change make possible to translate the fix for Subject index that now live in p.a.querystring code (that is quite ugly) to something more clean (the Subject index modifier is part of the branch).