Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plip 10359 - Security Control Panel migration #35

Merged
merged 2 commits into from Feb 4, 2015

Conversation

jcerjak
Copy link
Member

@jcerjak jcerjak commented Jan 27, 2015

Read security settings from the registry instead of portal properties. This is part of work on the security control panel migration: plone/Products.CMFPlone#216

This should be merged along with plone/Products.CMFPlone#362

@jcerjak
Copy link
Member Author

jcerjak commented Feb 1, 2015

There's one robot test failing on my machine with CMFPlone 4.3.4.1 (also on master branch), maybe it's an issue with my environment:

Test user creation and login as created user                          
2015-02-01 15:32:26,213 - Zope.SiteErrorLog - ERROR - 1422801146.210.81995210179 http://localhost:55001/plone/login_form
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFFormController.FSControllerPageTemplate, line 91, in __call__
  Module Products.CMFFormController.BaseControllerPageTemplate, line 31, in _call
  Module Shared.DC.Scripts.Bindings, line 322, in __call__
  Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
  Module Products.CMFCore.FSPageTemplate, line 237, in _exec
  Module Products.CMFCore.FSPageTemplate, line 177, in pt_render
  Module Products.PageTemplates.PageTemplate, line 79, in pt_render
  Module zope.pagetemplate.pagetemplate, line 126, in pt_render
   - Warning: Compilation failed
   - Warning: zope.tal.taldefs.TALError: Invalid variable name "join python:test(join and checkPermission('Add portal member', context), join, '')" in expression u"join python:test(join and checkPermission('Add portal member', context), join, '')", at line 24, column 9
PTRuntimeError: ['Compilation failed', 'zope.tal.taldefs.TALError: Invalid variable name "join python:test(join and checkPermission(\'Add portal member\', context), join, \'\')" in expression u"join python:test(join and checkPermission(\'Add portal member\', context), join, \'\')", at line 24, column 9']
| FAIL |
Page should have contained element '__ac_name' but did not

Let's see what travis says.

@datakurre
Copy link
Member

@jcerjak At least one build at Travis was green (well, one of the matrix), so this was ok. Thanks. The failing Travis-parts are not your fault.

datakurre added a commit that referenced this pull request Feb 4, 2015
Plip 10359 - Security Control Panel migration
@datakurre datakurre merged commit c5e344a into master Feb 4, 2015
@datakurre datakurre deleted the plip10359-security-controlpanel branch February 4, 2015 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants