Don't let HTML tile fail on non ascii content #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (but we need to fix the unrelated Travis issue)
Do you know, how did you end up with HTML tile having encoded data? Was it reproducible? (Because the real issue might be elsewhere.)
…On 18. huhtikuuta 2017 klo 9.31 +0300, Tom Gross ***@***.***>, wrote:
You can view, comment on, or merge this pull request online at:
#66
Commit Summary
Don't let HTML tile fail on non ascii content
File Changes
M .gitignore (https://github.com/plone/plone.app.standardtiles/pull/66/files#diff-0) (3)
M CHANGES.rst (https://github.com/plone/plone.app.standardtiles/pull/66/files#diff-1) (4)
M plone/app/standardtiles/html.py (https://github.com/plone/plone.app.standardtiles/pull/66/files#diff-2) (3)
M plone/app/standardtiles/tests/test_media.py (https://github.com/plone/plone.app.standardtiles/pull/66/files#diff-3) (9)
Patch Links:
https://github.com/plone/plone.app.standardtiles/pull/66.patch
https://github.com/plone/plone.app.standardtiles/pull/66.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#66), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAJyv773n2n7XvEVqg-KPrgEOiq7jYJeks5rxFjEgaJpZM4M_7R0).
|
|
@datakurre I'm confused myself. Because we obviously have umlauts everywhere in our site but this issue poped out suddenly. I suspect it is a copy&paste issue from Word with a double encoding or something. |
tomgross
force-pushed
the
fix_html_encoding
branch
from
c7678d1
to
232dc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.