Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing content with some additional fields #68

Merged
merged 7 commits into from
May 21, 2017

Conversation

cekk
Copy link
Member

@cekk cekk commented May 19, 2017

I've added 4 additional fields to this tile:

  • show_image
  • show_text
  • show_comments
  • tile_class

In this way, editors can choose which parts of the content need to be showed or not.
Our customers are used to use a similar portlet (redturtle.portlet.content), and i think that this could be a nice improvement for this tile.

tile_class field is another field that we commonly use, because it allows the editors to "mark" a portlet/tile with a specific (one or more) css class. This is helpful if we provide several different layouts for the same tile and they can choose which layout to use in every single tile.

For me, this field (tile_class) could be useful in every standard tile.

What do you think about this PR?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 83.859% when pulling fd1ccb8 on cekk-existingcontent-additional-fields into ef90122 on master.

@cekk
Copy link
Member Author

cekk commented May 19, 2017

i have only one question about translations: what's the official way to add these new fields in p.a.locales translations? There is a script that handle all p.a.* plone core translations?

@datakurre datakurre merged commit f0e2ac9 into master May 21, 2017
@datakurre
Copy link
Member

@cekk Thanks.

About locales. The current issue seem to be that because standardtiles is still not in core (and probably will not be in the near future, it is not yet included in plone.app.locales). I believe, it would be ok to simply add locales-directory and message catalog for plone domain into plone.app.standardtiles. It could not override anything from plone.app.locales, but would add the missing ones.

@datakurre datakurre deleted the cekk-existingcontent-additional-fields branch May 21, 2017 11:24
@cekk
Copy link
Member Author

cekk commented May 22, 2017

Ok, thanks..in that case i'll create a new PR with translations.
@datakurre one last question: what do you think about adding a customizable css class field to other tiles?
I don't know if it's a good idea for "field" tiles like title or description, but for other tiles could be useful (for example embed or collections)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants