Merge pull request #200 from plone/issue-199

Fix unclosed file
plone · Sep 9, 2021 · 28d4365 · 28d4365
2 parents 2aab605 + 4f1fb0d
commit 28d4365
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/news/199.bugfix b/news/199.bugfix
@@ -0,0 +1,2 @@
+Fix unclosed file when reading manifest.cfg
+[petschki]
diff --git a/src/plone/app/theming/utils.py b/src/plone/app/theming/utils.py
@@ -471,9 +471,8 @@ def getThemeFromResourceDirectory(resourceDirectory):
     """
     name = resourceDirectory.__name__
     if resourceDirectory.isFile(MANIFEST_FILENAME):
-        manifest = getManifest(
-            resourceDirectory.openFile(MANIFEST_FILENAME), MANIFEST_FORMAT
-        )
+        with resourceDirectory.openFile(MANIFEST_FILENAME) as manifest_fp:
+            manifest = getManifest(manifest_fp, MANIFEST_FORMAT)
     else:
         manifest = {}