Accept a fieldname in get_original_value in our scaling code. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for recent plone.namedfile versions.
Use the default plone.namedfile and plone.scale on Plone 6. On Plone 5 use newer versions.
We had one test using the image as property, and one getting the image from data. They both tested the tag and the scale methods. I have now split those two. And for the scale method we tried the 'mini' scale, which is the same size as the original image we use. So use thumb instead. That should flush out some more problems. And add tests calling scale with width=10. I am getting an error in the combination of data and tag, and suspected data and scale would fail as well. This would make that clearer. Currently only `testImageScalingTagViaData` is failing. In the tag we expect a width and height of 10, because we ask for this. Instead we get 400 by 400. Quite strange, since the original is 200 by 200... Might need another fix in plone.namedfile or plone.scale.
|
This needs plone/plone.scale#65 which itself needs more fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for recent plone.namedfile versions.