Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in site syndication settings when upgrading. #318

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix error in site syndication settings when upgrading. #318

merged 2 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. Fix error in site syndication settings when upgrading. 

    Fixes #315
    @mauritsvanrees
    mauritsvanrees committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c8cd2b7 View commit details
    Browse the repository at this point in the history

  2. site syndication: fix TypeError when site_rss_items value is None. 

    I ran `black` as well.  The real change is on this line:

    items = list(record.value) if record.value else ()

Traceback:

```
Traceback (most recent call last):
  File "/Users/maurits/shared-eggs/cp310/Products.CMFPlone-6.0.7rc1-py3.10.egg/Products/CMFPlone/MigrationTool.py", line 289, in upgrade
    step["step"].doStep(setup)
  File "/Users/maurits/shared-eggs/cp310/Products.GenericSetup-3.0.1-py3.10.egg/Products/GenericSetup/upgrade.py", line 193, in doStep
    self.handler(tool)
  File "/Users/maurits/shared-eggs/cp310/plone.app.upgrade-3.0.7-py3.10.egg/plone/app/upgrade/v60/final.py", line 183, in fix_syndication_settings
    items = list(record.value)
TypeError: 'NoneType' object is not iterable
```
    @mauritsvanrees
    mauritsvanrees committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e7877a7 View commit details
    Browse the repository at this point in the history