Skip to content

Commit

Permalink
remove dependencies on zope.app.container and rwproperty
Browse files Browse the repository at this point in the history
  • Loading branch information
davisagli committed Nov 6, 2014
1 parent d034141 commit b602e46
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Expand Up @@ -4,6 +4,9 @@ Changelog
1.2.1 (unreleased)
------------------

- Remove dependencies on zope.app.container and rwproperty.
[davisagli]

- Added Italian translations.
[cekk]

Expand Down
5 changes: 2 additions & 3 deletions plone/app/versioningbehavior/behaviors.py
Expand Up @@ -4,7 +4,6 @@
from plone.autoform.interfaces import IFormFieldProvider
from plone.dexterity.interfaces import IDexterityContent
from plone.supermodel import model
from rwproperty import getproperty, setproperty
from z3c.form.interfaces import IAddForm
from z3c.form.interfaces import IEditForm
from zope import schema
Expand Down Expand Up @@ -54,11 +53,11 @@ class Versionable(object):
def __init__(self, context):
self.context = context

@getproperty
@property
def changeNote(self):
return ''

@setproperty
@changeNote.setter
def changeNote(self, value):
# store the value for later use (see events.py)
annotation = IAnnotations(self.context.REQUEST)
Expand Down
2 changes: 1 addition & 1 deletion plone/app/versioningbehavior/configure.zcml
Expand Up @@ -45,7 +45,7 @@

<subscriber
for="plone.app.versioningbehavior.behaviors.IVersioningSupport
zope.app.container.interfaces.IObjectAddedEvent"
zope.lifecycleevent.interfaces.IObjectAddedEvent"
handler=".subscribers.create_version_on_save"
/>

Expand Down
2 changes: 1 addition & 1 deletion plone/app/versioningbehavior/subscribers.py
Expand Up @@ -5,7 +5,7 @@
from Products.CMFEditions.interfaces.IArchivist import ArchivistUnregisteredError
from Products.CMFEditions.interfaces.IModifier import FileTooLargeToVersionError
from Products.CMFPlone.utils import base_hasattr
from zope.app.container.interfaces import IContainerModifiedEvent
from zope.container.interfaces import IContainerModifiedEvent


def create_version_on_save(context, event):
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Expand Up @@ -46,9 +46,8 @@
'plone.dexterity',
'plone.namedfile[blobs]',
'Products.CMFEditions>2.2.9',
'rwproperty',
'setuptools',
'zope.app.container',
'zope.container',
],
tests_require=tests_require,
extras_require=dict(tests=tests_require),
Expand Down

1 comment on commit b602e46

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=a51df60f94f8406483a01c55c1744a59
plone-4.3-python-2.6 [SUCCESS]
plone-4.3-python-2.7 [SUCCESS]
plone-5.0-python-2.7 [SUCCESS]

Please sign in to comment.