Update widget templates with newest z3c.form extendable attributes.

[petschki]

This PR proposes:

• cleaning up widget templates with new chameleon attribute interpolation wich is possible since z3c.form>=5.1.
• getting rid of lxml pattern widget creation in favor of z3c.form extendable attributes.
• cleaning up browser add/edit view overrides as this will be no longer needed for pattern widget rendering.

Point 2 and 3 came into my mind while cleaning up some widget templates. I'll come up with some commits which will outline my idea of how to get rid of the lxml created widget markup.

This is a major but internal overhaul of the z3c.form widget override story and should not break any core packages. Though if someone has made z3c.jbot overrides of plone.app.z3cform widget templates s/he must update them accordingly (or remove them completely in favor of the new implementation).

[mister-roboto]

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[gforcada]

The CI failures for test and coverage is about the new version pin.

On our constraints.txt file we have z3c-form==4.3 while we define on setup.py z3c-form>=5.1.

Can we get a PR that updates z3c.form on buildout.coredev first? 🤞🏾

Once that passes, we need to update the constraints file (so far @mauritsvanrees work, sorry to put more burden on you 😓 ) and finally we can get this PR to be tested 🎉

It's a bit of a 🐜 🐜 🐜 work, but this way we ensure all pipelines from all packages keep working 😅

Whenever we introduce mxdev, we will be able to, at least locally, check the package before we have a newer version pin blessed generally, which can be a big improvement IMHO... some more work on each PR probably, but if we want to get CI to work always, we have to put some discipline and effort to it 😅

/cc @ericof @jensens @fredvd @mauritsvanrees how does that sound?

[gforcada]

Changes LGTM, we need to fix the pipeline, as I mentioned in another comment, and resolve the changes proposed by @thet 👍🏾

Looks great! 🌟

[petschki]

I would say, these changes target Plone 6.1+. I can create a 4.3.x branch here for the buildout.coredev=6.0 branch and move on with version 4.4.x on master branch ...

[petschki]

I saw that I'm able to override the constraints with .meta.toml configuration ... nice. But there is no https://dist.plone.org/release/6.1-dev/constraints.txt 😅

[mauritsvanrees]

The changes seem better for 6.1 indeed.

I have created a very preliminary version of https://dist.plone.org/release/6.1-dev/
I copied the requirements.txt and constraints.txt from 6.0-dev, and changed the pins for z3c.form and plone.app.multilingual.
There is a good chance that this will only work if you have a checkout of Products.CMFPlone and Plone. I did not try it out at all. But at least there is something to play with now.

[petschki]

Thank you! I'll give it a try now.

[petschki]

Well @gforcada the new constraints.txt from @mauritsvanrees did the trick ... implemented in .meta.toml... no need for extra checkouts 🎉

[petschki]

There we go ... this is the new base for "pattern" widgets: 2c7558b ... the pattern_options are set inside attributes and the pattern class in update() to ensure correct css class stacking.

The QueryStringWidget is a simple example of the new implementation: abe1213

/cc @gforcada @thet

[mauritsvanrees]

Hurray! That looks much simpler!

[petschki]

The new button implementation also fixes #142 as we do not need the add/edit form overrides for ActionButtons anymore.

[petschki]

@gforcada the meta/dependencies checker says that plone.dexterity is missing in test requiries but it is defined here: https://github.com/plone/plone.app.z3cform/pull/181/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R19

I do not really know how to fix that?

[mauritsvanrees]

@gforcada the meta/dependencies checker says that plone.dexterity is missing in test requiries but it is defined here: https://github.com/plone/plone.app.z3cform/pull/181/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R19

I do not really know how to fix that?

The problem is that plone.dexterity is both in install_requires and in test. Since it is now only used in tests, it should be removed from install_requires.

I guess the message could be a bit clearer.

[petschki]

The problem is that plone.dexterity is both in install_requires and in test. Since it is now only used in tests, it should be removed from install_requires.

I guess the message could be a bit clearer.

Thanks! Now I have to take a look why the build is broken 😅

[petschki]

Build is green now. @thet wanna take a look?

[MrTango]

Is there anything we should update in docs, for this changes?
Forms/Widgets?

[petschki]

Not for this change. This is almost all internal stuff. But the widget import location should be changed in the docs. Since version 4.0.x we've implemented all z3c.form browser widgets with Bootstrap 5 flavor here. I'll update it in the doc PR.

[petschki]

Update: the imports are fine for now. We need to think about this when we update the widget docs for Plone 6.1 ...