Fix lost support for contents without acquisition #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keul
referenced
this pull request
Feb 15, 2013
|
Hi @keul. Thanks for your pull request! I've gone ahead and started a merge test for you: You can check on the results at at the above link, or just wait a little while and I'll report them here. I'll also keep track of any future changes made to this pull request or to the Plone core build. If you'd like to manually run the merge tests at any point, you can do so via the link above. |
|
Looks good; thanks. |
davisagli
added a commit
that referenced
this pull request
Feb 19, 2013
Fix lost support for contents without acquisition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 587e229#commitcomment-2606236
Apart the fix discussed in the commit above, I found that the widget class was not covered by tests.
I added a minimal test for the acquisition stuff but is probably ugly, so nuke it away if is not appropriate