Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dummy security manager on test tear down #36

Merged
merged 2 commits into from Oct 3, 2018
Merged

Remove the dummy security manager on test tear down #36

merged 2 commits into from Oct 3, 2018

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Oct 3, 2018 •
edited

Refs. plone/Products.CMFPlone#2560

Note: the tearDown was removed in #32

davisagli
davisagli approved these changes Oct 3, 2018
View reviewed changes
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe AccessControl should register a cleanup function with zope.testing so that this is taken care of by the UNIT_TESTING layer. But this LGTM as long as jenkins builds pass.

@ale-rt ale-rt merged commit 6b39d44 into master Oct 3, 2018
@ale-rt ale-rt deleted the python3 branch October 3, 2018 15:08
ale-rt added a commit to plone/buildout.coredev that referenced this pull request Oct 3, 2018
@ale-rt
PR plone/plone.autoform#36 was merged
0cbc2b6
@ale-rt ale-rt mentioned this pull request Oct 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ale-rt @davisagli @jenkins-plone-org