Improve testing for single item batch. Only fix self.first if sequenc…

…e is bigger than one
plone · Mar 5, 2014 · 3eaaab6 · 3eaaab6
1 parent 7457f41
commit 3eaaab6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/plone/batching/batch.py b/plone/batching/batch.py
@@ -51,7 +51,7 @@ def initialize(self, start, end, size):
         self.end = end
 
         self.first = max(start - 1, 0)
-        if self.start == self.end:
+        if self.start == self.end and self.sequence_length > 1:
             self.first = self.end
         self.length = self.end - self.first
 

diff --git a/plone/batching/tests.py b/plone/batching/tests.py
@@ -118,6 +118,10 @@ def test_batch_bsize(self):
         batch = BaseBatch(sequence, 10, start=280)
         self.assertEqual(batch.length, 0)
 
+        # Single item batch
+        batch = BaseBatch(sequence[0:1], 10)
+        self.assertEqual(batch.length, 1)
+
 
 class TestQuantumBatch(unittest.TestCase):