stdout/stderr logging option #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is a draft, you can open/convert the PR in/to draft mode, if this is ready for merge please remove draft statement from title. Anyway, a non-draft PR with uppercase draft in title is confusing. |
mamico
changed the title
|
@mamico Niice! I think this should be the default behavior. Logging into files is not in accordance with Best practices for writing Dockerfiles But we didn't have this option when we first created this image: docker-library/official-images#1434 (comment) |
avoinea
requested changes
May 6, 2021
avoinea
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using kubernetes we found sometimes useful to collect logging from pod using stdout/stderr instead of local files.
This is a try to address this requirement.
If you think that could be useful and properly implemented I could spread changes to the other docker images.