Support for allowed content types. (Branch for 5.x) #159
Conversation
Support to constrain files to specific media types with a "accept" attribute on file and image fields, just like the "accept" attribute of the HTML file input. Fixes: #157
Change get_contenttype to support common types which are or were not registered with IANA, like image/webp or audio/midi. Note: image/webp is already a IANA registered type and also added by Products.MimetypesRegistry.
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
1 similar comment
|
@jenkins-plone-org please run jobs |
thet
force-pushed
the
allowed_content_types--5.x
branch
from
10a6d54
to
a38d765
Compare
|
@jenkins-plone-org please run jobs |
Mostly I want to trigger the pre-commit tests to run again.
[ci skip]
|
I am testing this together with plone/plone.formwidget.namedfile#68 on Jenkins on Plone 5.2. But it is a bit late to add new features to Plone 5.2, which is already officially unmaintained. I am happy with the feature though, so let's do this:
I will make branches. |
|
There are two robot test failures on 2.7, but they seem unrelated. I merge the two PRs. |
|
|
Support to constrain files to specific content types with a "allowedContentTypes" attribute on file and image fields.
Fixes: #157
BRANCH FOR 5.x / Plone 5.x
Related: #158