You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried plone.openid and plone.app.openid on a Plone 5.1.5 site, because we might have a use case for it. It did not work, so we will skip it. But let me list two problems I saw.
For me it goes wrong in the plone.openid authentication plugin. You don't really see anything in the logs, because errors are swallowed in PAS plugins. But with a pdb I can see more.
First failure is because the login key is None, giving an AttributeError: 'NoneType' object has no attribute 'encode'. The login None is there because PAS inserts it, trying to lowercase the existing login key.
I tried setting login to empty string, but then I got a seemingly unrelated failure.
Ah, no, wait: when I remove the login None instead of changing it to an empty string, it actually works. The other error is no longer there.
Okay, I will just fix that. I may still not end up using this package, but this can help others.
The text was updated successfully, but these errors were encountered:
Branch: refs/heads/master
Date: 2019-03-29T15:39:27+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.openid@beeabfb
Fixed error caused by PAS inserting `login=None` in the openid query.
Fixesplone/plone.openid#10
Files changed:
M CHANGES.rst
M plone/openid/plugins/oid.py
I tried plone.openid and plone.app.openid on a Plone 5.1.5 site, because we might have a use case for it. It did not work, so we will skip it. But let me list two problems I saw.
For me it goes wrong in the
plone.openid
authentication plugin. You don't really see anything in the logs, because errors are swallowed in PAS plugins. But with a pdb I can see more.It always fails in the line that basically checks if the query is valid.
My OpenID provider was a Django site. The query parameters at this point were:
First failure is because the
login
key is None, giving anAttributeError: 'NoneType' object has no attribute 'encode'
. The login None is there because PAS inserts it, trying to lowercase the existing login key.I tried setting login to empty string, but then I got a seemingly unrelated failure.
Ah, no, wait: when I remove the login None instead of changing it to an empty string, it actually works. The other error is no longer there.
Okay, I will just fix that. I may still not end up using this package, but this can help others.
The text was updated successfully, but these errors were encountered: