Query registry once

instead of querying it for each img tag.
plone · Jun 26, 2023 · b619daf · b619daf
1 parent e63ba77
commit b619daf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/news/less_call_to_registry.internal b/news/less_call_to_registry.internal
@@ -0,0 +1,2 @@
+Call registry once per filter rather than for each img tag.
+[gotcha]
diff --git a/plone/outputfilters/filters/picture_variants.py b/plone/outputfilters/filters/picture_variants.py
@@ -25,6 +25,7 @@ def __init__(self, context=None, request=None):
         self.context = context
         self.request = request
         self.img2picturetag = Img2PictureTag()
+        self.all_picture_variants = get_picture_variants()
 
     def __call__(self, data):
         soup = BeautifulSoup(safe_text(data), "html.parser")
@@ -33,7 +34,9 @@ def __call__(self, data):
             picture_variant_name = elem.attrs.get("data-picturevariant", "")
             if not picture_variant_name:
                 continue
-            picture_variants_config = get_picture_variants().get(picture_variant_name)
+            picture_variants_config = self.all_picture_variants.get(
+                picture_variant_name
+            )
             if not picture_variants_config:
                 logger.warning(
                     "Could not find the given picture_variant_name {}, leave tag untouched!".format(