Use AutoExtensibleForm in both Plone 5 and Plone 4 (when applicable) #12
Conversation
| USE_AUTOFORM = IAutoExtensibleForm.implementedBy(base.AddForm) or PLONE5 | ||
| try: | ||
| import plone.app.widgets # noqa | ||
| USE_PAE = True |
There was a problem hiding this comment.
What does USE_PAE stand for - why not e.g. USE_PAW (Plone.App.Widgets)?
There was a problem hiding this comment.
@petri While this indeed a typo, you are commenting on code from a reverted commit within this pull request; please review the final changes.
There was a problem hiding this comment.
Would be wise to rebase the commits to remove reverted commits then
1.x is installed, with form hints to ensure TinyMCE configuration matches that generated in plone.app.widgets.
seanupton
added
32 needs: review
04 type: enhancement
01 type: bug
and removed
04 type: enhancement
labels
|
This master branch is not used in buildout.coredev 4 anymore (it sticks to 2.x). So the code of this PR is not tested with 4.x - is this intended? If yes I'am ok merging this, since the tested parts are working in 5.0/5.1. |
|
@jensens Plone 4.x use is intended, and seems to work well. This is a prerequsite for plone/plone.app.widgets#144 (1.x branch of plone.app.widgets) TinyMCE to work properly (configured) with static text portlet. Essentially, this feature detects either PLONE5 or plone.app.widgets 1.x -- if either is present, AutoExtensibleForm is used and widget directive points to correct widget (either from plone.app.z3cform in Plone 5.x OOTB of plone.app.widgets.dx in Plone 4 integration). A merge would be appreciated. Thanks. |
When Plone 4 has plone.app.widgets installed, use AutoExtensibleForm, which will make TinyMCE from plone.app.widgets 1.x work properly in the Plone 4 context. Effectively makes the plone.app.widgets 1.x behavior more closely match Plone 5.