Skip to content

Commit

Permalink
Merge pull request #186 from plone/isort-script
Browse files Browse the repository at this point in the history 
WIP install isort script
  • Loading branch information
@jensens
jensens committed Feb 29, 2016
2 parents f13beb5 + f36a9f5 commit 189d5ad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ Change history
2.3 (unreleased)
----------------

- Nothing changed yet.
- Install isort script if flake8-isort is installed as well.
[gforcada]


2.2 (2016-02-20)
Expand Down
4 changes: 4 additions & 0 deletions plone/recipe/codeanalysis/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ def add_script(cmd, **kwargs):
(self.name, self.__module__, 'code_analysis'),
arguments=arguments
)
# isort
if 'flake8-isort' in self.extensions:
add_script('isort')

# others
for klass in all_checks:
instance = klass(self.options)
Expand Down

2 comments on commit 189d5ad

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/15//violations

plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters

Follow these instructions to reproduce it locally.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/16/violations

plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters

Follow these instructions to reproduce it locally.

Please sign in to comment.