Merge pull request #158 from plone/remove-debug-statements

Remove debug statements
plone · Sep 17, 2015 · 8e21ade · 8e21ade
2 parents a80806d + 4cfb3c7
commit 8e21ade
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 127 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,10 +1,12 @@
 Change history
 ==============
 
-2.0.3 (unreleased)
-------------------
+2.1 (unreleased)
+----------------
 
-- Nothing changed yet.
+- Remove debug statements checker, flake8-debugger, flake8-print and jshint can do the
+  same job.
+  [gforcada]
 
 
 2.0.2 (2015-09-03)

diff --git a/README.rst b/README.rst
@@ -104,8 +104,6 @@ This configuration looks like this:
     imports = True
     pep3101 = True
     prefer-single-quotes = True
-    debug-statements = True
-    debug-statements-exclude = ${:jscs-exclude}
     # i18n
     utf8-header = True
     find-untranslated = True
@@ -417,14 +415,6 @@ The recipe supports the following options:
     Allows you to specify directories and/or files which you don't want to be
     checked. Default is none.
 
-**debug-statements**
-    If set to True, scan Python and Javascript files looking for debug-like
-    statements like ``print`` and ``console.log``. Default is ``False``.
-
-**debug-statements-exclude**
-    Allows you to specify directories and/or files which you don't want to be
-    checked. Default is none.
-
 **hasattr**
     If set to True, scan Python files looking for ``hasattr`` calls.
     This is considered bad practice as it swallows exceptions.

diff --git a/plone/recipe/codeanalysis/__init__.py b/plone/recipe/codeanalysis/__init__.py
@@ -2,7 +2,6 @@
 from plone.recipe.codeanalysis.check_manifest import CheckManifest
 from plone.recipe.codeanalysis.clean_lines import CleanLines
 from plone.recipe.codeanalysis.csslint import CSSLint
-from plone.recipe.codeanalysis.debug_statements import DebugStatements
 from plone.recipe.codeanalysis.deprecated_aliases import DeprecatedAliases
 from plone.recipe.codeanalysis.flake8 import Flake8
 from plone.recipe.codeanalysis.i18ndude import I18NDude
@@ -24,7 +23,6 @@
     CSSLint,
     CheckManifest,
     CleanLines,
-    DebugStatements,
     DeprecatedAliases,
     Flake8,
     HasAttr,
@@ -89,8 +87,6 @@ def __init__(self, buildout, name, options):
         self.options.setdefault('pep3101', 'False')
         # imports
         self.options.setdefault('imports', 'False')
-        # Debug statements
-        self.options.setdefault('debug-statements', 'False')
         # Jenkins output
         self.options.setdefault('jenkins', 'False')
         self.options.setdefault('flake8-filesystem', 'False')

diff --git a/plone/recipe/codeanalysis/debug_statements.py b/plone/recipe/codeanalysis/debug_statements.py
diff --git a/plone/recipe/codeanalysis/tests/test_debug_statements.py b/plone/recipe/codeanalysis/tests/test_debug_statements.py