Add basic manifest check. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +40,7 @@ | |||
| PreferSingleQuotes, | |||
| UTF8Headers, | |||
| ZPTLint, | |||
| CheckManifest, | |||
There was a problem hiding this comment.
Can we keep them sorted alphabetically :)
There was a problem hiding this comment.
Yes, this also defines the order in which they are run.
|
what about adding some tests? |
|
@hvelarde can you please read again what i wrote in the PR description? |
|
@saily morning blindness, sorry... |
saily
force-pushed
the
master
branch
2 times, most recently
from
e47d682
to
60696fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #69, if i look into the code, the discussion was pretty long, but the code fragment is really compact.
A test is missing, so i marked this PR as [WIP], but just to let you know i'm working on it.