Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extra: plone #199

Closed
wants to merge 2 commits into from
Closed

New extra: plone #199

wants to merge 2 commits into from

Conversation

gforcada
Copy link
Sponsor Member

@gforcada gforcada commented Dec 7, 2016

p.r.codeanalysis is meant to be general purpose tool rather than a plone-only tool.

Thus it does not make sense to add on the recommended list of flake8 plugins the ones that are plone specific.

To that extend a new extra is born: plone.

p.r.codeanalysis is meant to be general purpose tool rather than a plone-only tool.

Thus it does not make sense to add on the recommended list of flake8 plugins the ones that are plone specific.

To that extend a new extra is born: ``plone``.
@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 94.962% when pulling 06fa452 on gforcada-plone-extra into 4d133d9 on master.

@tisto
Copy link
Sponsor Member

tisto commented Dec 7, 2016

@gforcada p.r.codeanalysis was meant to be to be useful for any buildout-based project. Though, 99% of the users are most likely plone users. Therefore I'm not sure if it make much sense to make it more complex for the 99% just to serve the 1% (and they don't even have any real disadvantage).

@jensens
Copy link
Sponsor Member

jensens commented Jan 16, 2017

So whats the state here? I agree we should primary support Plone. So there is currently no way to install without Plone specific addons.

But do the installed Plone addons pull in some nasty dependency? Or is it just dead code?

In latter case I would not mind at all, since the plugins can be configured individually.

@iham
Copy link
Member

iham commented Jan 30, 2017

as it is a plone-recipe i thought it is already a plone-related package...

@adamcheasley
Copy link

I have never seen buildout used outside the plone community. If this is a tool which requires buildout, then I don't see it being used much outside the plone community anyway.

@icemac
Copy link

icemac commented Feb 1, 2017

@adamcheasley There are actually people using zc.buildout outside plone: We use it for union.cms a CMS based on Zope 2 but not on Plone. There are even buildout recipes for Django although I do not know whether they are still used widely.
I'd personally like to use plone.recipe.codeanalysis outside Plone.

@adamcheasley
Copy link

@icemac I've seen the buildout recipes for django. I've never seen them used. No idea why anyone would want to either. I'm sure buildout is used outside of zope and plone, but I would imagine the percentage is tiny. As @tisto says, this would be a lot of work for that tiny percentage.

@tisto
Copy link
Sponsor Member

tisto commented Feb 1, 2017

Just to be clear. This discussion is not about if p.r.codeanalysis can be used by other buildout-based projects (this is the case and will remain). This is just about the question if we make "plone" just one of the use-cases or if it still remains the main use case. We could also discuss to rename "recommended" to "plone". Though, I don't think this is worth the effort to be honest.

@jensens
Copy link
Sponsor Member

jensens commented Feb 22, 2017

After all it seems this change was overall not accepted? I close this one (but do not delete the branch for now). If you think this was wrong please reopen and go on.

@jensens jensens closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants