Fix code analysis #206
Merged
Fix code analysis #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the One solution could be https://stackoverflow.com/questions/14058453 |
|
Logging to stdout could help. On the other hand: why are we against print statements? I think that is because it is not good in a web server environment: all output should go to a log file there, so printing is bad. For a code analysis script on the command line, printing is fine IMHO. So we might disable the printing check for this package. |
|
@mauritsvanrees yeah, that's true as well, I didn't want to have a special set of plugins for p.r.codeanalysis. The canonical place for plugins anyway should be on bobtemplates.plone or buildout.coredev anyway... I will remove that plugin at night, thanks for the review! |
gforcada
force-pushed
the
fix-code-analysis
branch
4 times, most recently
from
a4ffb95
to
7480e1a
Compare
Done in a breeze thanks to ``add-trailing-comma`` python package!
This way flake8 linters do not complain about an unindexed parameter, while at the same time the tests keep working.
gforcada
force-pushed
the
fix-code-analysis
branch
from
7480e1a
to
ec56af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.