Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'find-untranslated-no-summary' option for i18ndude. #215

Merged
merged 2 commits into from Jan 18, 2018

Conversation

thomasmassmann
Copy link
Member

For bigger projects with a lot of pt files it's very hard to see the problematic templates if every file, even correct ones, is printed to the command line. This option (default to false, so no change in current installations) enables the --no-summary mode for i18ndude, which only shows the errors for each file.

@gforcada
Copy link
Sponsor Contributor

gforcada commented Jan 3, 2018

@tmassman please rebase on top of current master so that travis jobs have a green base 🙂

@tisto
Copy link
Sponsor Member

tisto commented Jan 4, 2018

I am wondering if it would make sense to add a more generic i18ndude command line parameter. Otherwise we would have to add a new p.r.codeanalysis option for every i18ndude param that exists.

@thomasmassmann
Copy link
Member Author

thomasmassmann commented Jan 4, 2018

@tisto, there are only two params for the find-untranslated command, and no other i18ndude command is used in p.r.codeanalysis. But if you have a suggestion on how to best do it here, please let me know.

@thomasmassmann
Copy link
Member Author

@gforcada rebase is done, what do you think?

@tisto tisto merged commit 7e3ec1a into master Jan 18, 2018
@tisto tisto deleted the tmassman-i18ndude branch January 18, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants