New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility of generated bin/zeopack #36

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@zopyx
Copy link
Member

zopyx commented Jan 8, 2019

@zopyx zopyx changed the title Python 3 compatibility Python 3 compatibility of generated bin/zeopack Jan 8, 2019

@mauritsvanrees
Copy link
Member

mauritsvanrees left a comment

LGTM.

Please start the tests on Jenkins:

  • Log in to jenkins.plone.org with your github account.
  • Go to the 'Build with parameters' form for all relevant Plone versions. You should see direct links to those versions under the 'Some checks haven’t completed yet' box of the pull request.
  • Paste the pull request url in that form and build it.

@zopyx zopyx merged commit 28d42ec into plone:master Jan 10, 2019

7 of 8 checks passed

Plone Jenkins CI - pull-request-5.2-3.6 Job finished with error status
Details
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.7 Job finished with success status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 62.667%
Details
@zopyx

This comment has been minimized.

Copy link
Member

zopyx commented Jan 10, 2019

sigh why isn't is easily possible to merge this PR? Just because the CI pukes randomly with some unrelated robotframework tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment