Fix bin/zinstance script for wsgi=on
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripping of the first argument of `argv` is already done again in https://github.com/zopefoundation/Zope/blob/master/src/Zope2/Startup/serve.py#L136 which is called by `Zope2.Startup.serve.main`.
|
Lgtm. We'll need to change https://github.com/plone/buildout.coredev/blob/ad56ba4955ce4930cd9fc4abb9754c12463f4943/wsgi.cfg#L47 (remove |
tschorr
approved these changes
Aug 22, 2018
Python 3 does not have an `__init__.py` in namespace packages installed via pip. (See https://www.python.org/dev/peps/pep-0420/.) This breaks the tests because `zc.buildout` which was installed via pip can no longer be found by the test script. Now `tox.ini` and `.travis.yml` install all packages via pip to resolve the iussue. (This led to some test failures in Python 2.7 which I fixed in the tests.)
|
Jenkins failure is unrelated (Jenkins was green without the Changelog modification). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping of the first argument of
argvis already done again in https://github.com/zopefoundation/Zope/blob/master/src/Zope2/Startup/serve.py#L136 which is called byZope2.Startup.serve.main.This extends the fix of #44, so I think no change log entry is needed.