Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask before pushing an updated version when running 'report'. #33

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Ask before pushing an updated version when running 'report'. #33

merged 1 commit into from
Mar 5, 2020

Conversation

mauritsvanrees
Copy link
Sponsor Member

Fixes #32

I am using this now in 5.2:

Newer version 2.4.4 is available for Products.CMFCore (Currently 2.4.2)
Update versions.cfg? (Y/n)
Ok to push coredev?? (Y/n)n

Works: the change remains local now.

@mister-roboto

This comment has been minimized.

Sign in to view
@gforcada gforcada merged commit 242fdf9 into master Mar 5, 2020
@gforcada gforcada deleted the maurits/issue-32-push-ask branch March 5, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteele esteele esteele approved these changes

@gforcada gforcada gforcada approved these changes

Assignees
No one assigned
Labels
01 type: bug 13 prio: normal 24 status: ready 32 needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report: when updating version, we should not push
4 participants
@mauritsvanrees @mister-roboto @esteele @gforcada