Fix #443, Ensure the userid returned by authenticateCredentials is …

…a byte string and not unicode.
plone · Nov 23, 2017 · 9ef3235 · 9ef3235
1 parent b654f21
commit 9ef3235
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -41,6 +41,9 @@ Bug Fixes:
   including all items recursively.
   [sneridagh]
 
+- Fix #443, Ensure the userid returned by `authenticateCredentials` is a byte string and not unicode.
+  [Gagaro]
+
 
 1.0a24 (2017-11-13)
 -------------------

diff --git a/src/plone/restapi/pas/plugin.py b/src/plone/restapi/pas/plugin.py
@@ -119,6 +119,9 @@ def authenticateCredentials(self, credentials):
 
         userid = payload['sub']
 
+        if isinstance(userid, unicode):
+            userid = userid.encode('utf8')
+
         if self.store_tokens:
             if userid not in self._tokens:
                 return None