Add group roles to @groups serializer

plone · Mar 4, 2019 · a430318 · a430318
1 parent 6758f1d
commit a430318
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 0 deletions.
diff --git a/news/682.feature b/news/682.feature
@@ -0,0 +1,2 @@
+- Add group roles to @groups serializer
+  [sneridagh]
diff --git a/src/plone/restapi/serializer/group.py b/src/plone/restapi/serializer/group.py
@@ -28,6 +28,7 @@ def __call__(self):
             'email': group.getProperty('email'),
             'title': group.getProperty('title'),
             'description': group.getProperty('description'),
+            'roles': group.getRoles(),
         }
 
 

diff --git a/src/plone/restapi/tests/http-examples/groups.resp b/src/plone/restapi/tests/http-examples/groups.resp
@@ -8,6 +8,10 @@ Content-Type: application/json
     "email": "", 
     "groupname": "Administrators", 
     "id": "Administrators", 
+    "roles": [
+      "Manager", 
+      "Authenticated"
+    ], 
     "title": "Administrators"
   }, 
   {
@@ -16,6 +20,10 @@ Content-Type: application/json
     "email": "", 
     "groupname": "Reviewers", 
     "id": "Reviewers", 
+    "roles": [
+      "Reviewer", 
+      "Authenticated"
+    ], 
     "title": "Reviewers"
   }, 
   {
@@ -24,6 +32,10 @@ Content-Type: application/json
     "email": "", 
     "groupname": "Site Administrators", 
     "id": "Site Administrators", 
+    "roles": [
+      "Site Administrator", 
+      "Authenticated"
+    ], 
     "title": "Site Administrators"
   }, 
   {
@@ -32,6 +44,9 @@ Content-Type: application/json
     "email": "ploneteam@plone.org", 
     "groupname": "ploneteam", 
     "id": "ploneteam", 
+    "roles": [
+      "Authenticated"
+    ], 
     "title": "Plone Team"
   }, 
   {
@@ -40,6 +55,7 @@ Content-Type: application/json
     "email": "", 
     "groupname": "AuthenticatedUsers", 
     "id": "AuthenticatedUsers", 
+    "roles": [], 
     "title": "Authenticated Users (Virtual Group)"
   }
 ]
diff --git a/src/plone/restapi/tests/http-examples/groups_created.resp b/src/plone/restapi/tests/http-examples/groups_created.resp
@@ -8,6 +8,10 @@ Location: http://localhost:55001/plone/@groups/fwt
   "email": "fwt@plone.org", 
   "groupname": "fwt", 
   "id": "fwt", 
+  "roles": [
+    "Manager", 
+    "Authenticated"
+  ], 
   "title": "Framework Team", 
   "users": {
     "@id": "http://localhost:55001/plone/@groups", 

diff --git a/src/plone/restapi/tests/http-examples/groups_filtered_by_groupname.resp b/src/plone/restapi/tests/http-examples/groups_filtered_by_groupname.resp
@@ -8,6 +8,9 @@ Content-Type: application/json
     "email": "ploneteam@plone.org", 
     "groupname": "ploneteam", 
     "id": "ploneteam", 
+    "roles": [
+      "Authenticated"
+    ], 
     "title": "Plone Team"
   }
 ]
diff --git a/src/plone/restapi/tests/http-examples/groups_get.resp b/src/plone/restapi/tests/http-examples/groups_get.resp
@@ -7,6 +7,9 @@ Content-Type: application/json
   "email": "ploneteam@plone.org", 
   "groupname": "ploneteam", 
   "id": "ploneteam", 
+  "roles": [
+    "Authenticated"
+  ], 
   "title": "Plone Team", 
   "users": {
     "@id": "http://localhost:55001/plone/@groups/ploneteam", 

diff --git a/src/plone/restapi/tests/http-examples/principals.resp b/src/plone/restapi/tests/http-examples/principals.resp
@@ -9,6 +9,9 @@ Content-Type: application/json
       "email": "ploneteam@plone.org", 
       "groupname": "ploneteam", 
       "id": "ploneteam", 
+      "roles": [
+        "Authenticated"
+      ], 
       "title": "Plone Team"
     }
   ], 

diff --git a/src/plone/restapi/tests/test_services_groups.py b/src/plone/restapi/tests/test_services_groups.py
@@ -62,6 +62,8 @@ def test_list_groups(self):
         self.assertEqual('Plone Team', ptgroup.get('title'))
         self.assertEqual('We are Plone', ptgroup.get('description'))
 
+        self.assertEqual(ptgroup.get('roles'), ['Authenticated'])
+
         # We don't want the group members listed in the overview as there
         # might be loads.
         self.assertTrue(