Skip to content

Commit

Permalink
Added Plone 5.2 to classifiers in setup.py.
Browse files Browse the repository at this point in the history 
[ci skip]
  • Loading branch information
@mauritsvanrees
mauritsvanrees committed Oct 1, 2018
1 parent 7ba3df1 commit ea5b7f4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"Framework :: Plone :: 4.3",
"Framework :: Plone :: 5.0",
"Framework :: Plone :: 5.1",
"Framework :: Plone :: 5.2",
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python",
Expand Down

3 comments on commit ea5b7f4

@tisto
Copy link
Member

@tisto tisto commented on ea5b7f4 Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritsvanrees we should add the classifier when we have tests and a release that works with Plone 5.2 IMHO. Any particular reason why you committed to master directly?

@mauritsvanrees
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto I did this to all packages in coredev 5.2 which are in sources.cfg and which already had Plone 5.1 in the classifiers. See plone/Products.CMFPlone#2524 (comment)
If you see reason to revert it in this case, that is fine with me.

@tisto
Copy link
Member

@tisto tisto commented on ea5b7f4 Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritsvanrees all good! If you do this for lots of packages at the same time it's a different trade-off. Thanks for your work and sorry for the noise!

Please sign in to comment.