Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures with Zope 4.5.2 on Python 2.7 #1019

Closed
mauritsvanrees opened this issue Nov 12, 2020 · 2 comments · Fixed by #1020
Closed

Test failures with Zope 4.5.2 on Python 2.7 #1019

mauritsvanrees opened this issue Nov 12, 2020 · 2 comments · Fixed by #1020
Labels
02 type: regression 11 prio: blocker 21 status: confirmed 31 needs: help

Comments

@mauritsvanrees
Copy link
Sponsor Member

Yesterday I added Zope to the checkouts in plone coredev 5.2. That causes test failures on Python 2.7 only.
Zope 4.5.2 was released today. Using it indeed gives the same problems.
This is caused by a change in headers in Zope. See my comment where I explain the current situation in more detail.

Note: the tests fail both with plone.restapi 6.x.x and master.
@mauritsvanrees
Copy link
Sponsor Member Author

I have reverted coredev to 4.5.1 for the moment.

@mauritsvanrees
Copy link
Sponsor Member Author

Cause found, see comment. We can fix it in plone.restapi code by making sure we set the Location header as a string, not unicode.

Warning for clarity: this seems not just a problem in the tests, but should be visible when you try it live with Zope 4.5.2.

mauritsvanrees added a commit that referenced this issue Nov 12, 2020
@mauritsvanrees
Fixed compatibility with Zope 4.5.2 by making sure Location header is…
79b624c 
… string.

On Python 2 it could be unicode for the users and groups end points.
Fixes #1019
@mauritsvanrees mauritsvanrees mentioned this issue Nov 12, 2020
Merged
mauritsvanrees added a commit that referenced this issue Nov 12, 2020
@mauritsvanrees
Fixed compatibility with Zope 4.5.2 by making sure Location header is…
833d134 
… string.

On Python 2 it could be unicode for the users and groups end points.
Fixes #1019
@mauritsvanrees mauritsvanrees mentioned this issue Nov 12, 2020
Closed
tisto pushed a commit that referenced this issue Nov 12, 2020
@mauritsvanrees
Fixed compatibility with Zope 4.5.2 by making sure Location header is…
daadd83 
… string. (#1020)

On Python 2 it could be unicode for the users and groups end points.
Fixes #1019
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Nov 12, 2020
@tisto
[fc] Repository: plone.restapi
83284a4 
Branch: refs/heads/master
Date: 2020-11-12T21:22:25+01:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.restapi@daadd83

Fixed compatibility with Zope 4.5.2 by making sure Location header is string. (#1020)

On Python 2 it could be unicode for the users and groups end points.
Fixes plone/plone.restapi#1019

Files changed:
A news/1019.bugfix
M src/plone/restapi/services/groups/add.py
M src/plone/restapi/services/users/add.py
tisto pushed a commit that referenced this issue Nov 12, 2020
@mauritsvanrees @tisto
Fixed compatibility with Zope 4.5.2 by making sure Location header is…
f460108 
… string. (#1020)

On Python 2 it could be unicode for the users and groups end points.
Fixes #1019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 type: regression 11 prio: blocker 21 status: confirmed 31 needs: help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Zope 4.5.2 compatibility: make sure Location header is string [master] plone/plone.restapi
1 participant
@mauritsvanrees