Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.restapi 6.4.1 shows "Volto Blocks" installer in add-on products controlpanel #895

Closed
erral opened this issue Mar 30, 2020 · 16 comments · Fixed by #1027
Closed

plone.restapi 6.4.1 shows "Volto Blocks" installer in add-on products controlpanel #895

erral opened this issue Mar 30, 2020 · 16 comments · Fixed by #1027

Comments

@erral
Copy link
Sponsor Member

erral commented Mar 30, 2020

I have added plone.restapi 6.4.1 to a Plone 4.3.x buildout, and after fighting buildout, I see "Volto Blocks" profile as installable in add-on products control panel

2020-03-30 13-24-15-ko-pantaila-argazkia

I expected to see the default plone.restapi profile.

I guess that in Plone 4.3.x Plone shows the alphabetically first profile, and "blocks" goes before "default".

@tisto
Copy link
Sponsor Member

tisto commented Apr 8, 2020

@erral yeah. that's a known issue that has indeed nothing to do with plone.restapi. hard to find a solution for this...

@avoinea
Copy link
Sponsor Member

avoinea commented Apr 8, 2020

I think renaming this

to something like vblocks or volto-blocks would fix it.

@erral
Copy link
Sponsor Member Author

erral commented Apr 8, 2020

Yes, the vblocks would fix it, in essence anything that alphabetically goes after "default" would do it.

And is necessary to be able to install plone.restapi in Plone 4.3.x.

@tisto
Copy link
Sponsor Member

tisto commented Apr 8, 2020

I'd be ok with a rename to "volto-blocks". The question would be is that a breaking change and do we need an upgrade step for this then?

@erral
Copy link
Sponsor Member Author

erral commented Apr 8, 2020

When do we need to install the "blocks" profile?

@avoinea
Copy link
Sponsor Member

avoinea commented Apr 8, 2020

From what I can see it just adds the volto.blocks behavior on Page.

Renaming it will break this:

<dependency>profile-plone.restapi:blocks</dependency>

within other packages metadata.xml

Respectively:

  • kitconcept.volto
  • kitconcept.voltodemo
  • eea.restapi

See https://github.com/search?q=profile-plone.restapi%3Ablocks&type=Code

@wesleybl
Copy link
Member

wesleybl commented Nov 6, 2020

@avoinea @tisto can we change the name? The other packages can be upgraded as well.

@avoinea
Copy link
Sponsor Member

avoinea commented Nov 6, 2020

@wesleybl 👍

@tisto
Copy link
Sponsor Member

tisto commented Nov 9, 2020

I am not sure if it is worth the hassle to change the names now. If we start with Plone 6 we might have to refactor things anyways.

@erral
Copy link
Sponsor Member Author

erral commented Nov 9, 2020

I would do the name change and release one final plone.restapi version for Plone 4.3.x with the name changed. This way all users wanting to use plone.restapi in Plone 4.3 will have a reference version that can be installed without issues through Plone Control Panel.

And then all efforts can go to Plone 5/6, with the wanted profile names or new features.

@tisto
Copy link
Sponsor Member

tisto commented Nov 9, 2020

If we remove that profile altogether we won't have that problem and all future versions of p.restapi can be used with Plone 4.

@erral
Copy link
Sponsor Member Author

erral commented Nov 9, 2020

That would be OK if we are not using that profile anywhere

@wesleybl
Copy link
Member

If we remove that profile altogether we won't have that problem and all future versions of p.restapi can be used with Plone 4.

@tisto is your idea to transfer the behavior of this profile to the default profile and remove the profile? Wouldn't that put unnecessary behavior on those who don't use Volto?

@tisto
Copy link
Sponsor Member

tisto commented Nov 11, 2020

@wesleybl no. Just move the Volto profile to another package. Those are important architectural decisions we have to make when moving towards Plone 6.

@wesleybl
Copy link
Member

@tisto Well, it looks like it will take time. I would like to see this problem resolved in the next release of plone.restapi. Can we change the name of the profile? I can test what happens, on portals that have the current profile installed. There will probably be no problem.

@wesleybl
Copy link
Member

Fix in 597d10d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants