-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plone.restapi 6.4.1 shows "Volto Blocks" installer in add-on products controlpanel #895
Comments
@erral yeah. that's a known issue that has indeed nothing to do with plone.restapi. hard to find a solution for this... |
I think renaming this
vblocks or volto-blocks would fix it.
|
Yes, the vblocks would fix it, in essence anything that alphabetically goes after "default" would do it. And is necessary to be able to install plone.restapi in Plone 4.3.x. |
I'd be ok with a rename to "volto-blocks". The question would be is that a breaking change and do we need an upgrade step for this then? |
When do we need to install the "blocks" profile? |
From what I can see it just adds the Renaming it will break this:
within other packages Respectively:
See https://github.com/search?q=profile-plone.restapi%3Ablocks&type=Code |
I am not sure if it is worth the hassle to change the names now. If we start with Plone 6 we might have to refactor things anyways. |
I would do the name change and release one final plone.restapi version for Plone 4.3.x with the name changed. This way all users wanting to use plone.restapi in Plone 4.3 will have a reference version that can be installed without issues through Plone Control Panel. And then all efforts can go to Plone 5/6, with the wanted profile names or new features. |
If we remove that profile altogether we won't have that problem and all future versions of p.restapi can be used with Plone 4. |
That would be OK if we are not using that profile anywhere |
@tisto is your idea to transfer the behavior of this profile to the default profile and remove the profile? Wouldn't that put unnecessary behavior on those who don't use Volto? |
@wesleybl no. Just move the Volto profile to another package. Those are important architectural decisions we have to make when moving towards Plone 6. |
@tisto Well, it looks like it will take time. I would like to see this problem resolved in the next release of plone.restapi. Can we change the name of the profile? I can test what happens, on portals that have the current profile installed. There will probably be no problem. |
Fix in 597d10d |
I have added plone.restapi 6.4.1 to a Plone 4.3.x buildout, and after fighting buildout, I see "Volto Blocks" profile as installable in add-on products control panel
I expected to see the default plone.restapi profile.
I guess that in Plone 4.3.x Plone shows the alphabetically first profile, and "blocks" goes before "default".
The text was updated successfully, but these errors were encountered: