Service base class #103
Merged
Service base class #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new base class defines a `reply()` method that can be overridden by service implementations.
|
Looks good to me. |
lukasgraf
added a commit
that referenced
this pull request
May 23, 2016
remove it from auto-checkout. After the change in #103 introducing a service base class that is based on plone.rest.Service we require at least plone.rest 1.0a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a base class for all services defined in plone.restapi that basically renders the results to JSON. This functionality has been removed in plone.rest (plone/plone.rest#52) an now needs to be done in plone.restapi.
Services now have to implement the
reply()method to process the request. This method should return a JSON serializable data structure or the no content marker.