Added support for nested schemas with resolveuid block deserializer #1595
Conversation
|
@JeffersonBledsoe thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
👷 Deploy Preview for plone-restapi processing.
|
✅ Deploy Preview for plone-restapi canceled.
|
JeffersonBledsoe
changed the title
|
@jenkins-plone-org please run jobs |
JeffersonBledsoe
changed the title
JeffersonBledsoe
changed the title
|
@jenkins-plone-org please run jobs |
|
@JeffersonBledsoe @razvanMiu I tested this with a large page from one of our projects and don't see any significant difference in performance. I think sub-blocks will end up getting processed twice, since the (de)serializer will be called once for the subblock and again for the top-level block, and the second one will recurse down into the subblocks. That's not necessarily a problem, but could be optimized in the future. |
As the initial implementation only iterated over the
smartfield, there may be a performance impact with this PR with very large blocks as there is no way of knowing if a nested value will have a smart field without iterating through them all. Any comments on this/ input on if this could be improved are welcomed!Closes #1594