Give Site Administrator permission to add users to groups #1751
Conversation
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
|
@jenkins-plone-org please run jobs |
The addMember method requires the user to have the "Manage Users" permission but the Site Administrator does not have this permission. Then we use the addPrincipalToGroup method, which does not require this permission.
|
While this fixes the immediate problem, I would question question why the two methods have different permissions - and if it would not be better to fix it there than working around here? |
|
@jensens this is the same solution used in the Classic UI. See @davisagli 's opinion on using |
got it, indeed. |
The
addMembermethod requires the user to have theManage Userspermission but the Site Administrator does not have this permission. Then we use theaddPrincipalToGroupmethod, which does not require this permission.fixes #1750