Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache rules for @site and @navroot #1779

Merged
merged 4 commits into from May 16, 2024
Merged

Conversation

mamico
Copy link
Member

@mamico mamico commented May 7, 2024

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

@mamico mamico requested a review from erral May 7, 2024 20:42
@mister-roboto

This comment was marked as resolved.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 1062d54
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/663b3d492981df0009a5c8c9

@mamico mamico requested a review from davisagli May 7, 2024 20:42
@erral
Copy link
Sponsor Member

erral commented May 8, 2024

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

It wasn't intentional at all.

@mamico
Copy link
Member Author

mamico commented May 8, 2024

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 15ac486 into main May 16, 2024
25 checks passed
@davisagli davisagli deleted the site_navroot_caching_rules branch May 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants