Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unittest2 imports. #299

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Remove unittest2 imports. #299

merged 1 commit into from
Mar 24, 2017

Conversation

tisto
Copy link
Sponsor Member

@tisto tisto commented Mar 24, 2017

No description provided.

@tisto
Copy link
Sponsor Member Author

tisto commented Mar 24, 2017

@lukasgraf @buchi would that be ok with you? Are you running Plone 4.3 on Python 2.6?

@tisto tisto requested review from lukasgraf and buchi March 24, 2017 12:05
@lukasgraf
Copy link
Member

lukasgraf commented Mar 24, 2017 •
edited

@tisto nope, we're on Python 2.7 everywhere where it matters, ok for us 👍 - thanks for checking :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.011% when pulling c160a48 on unittest2 into 8a63687 on master.

@tisto tisto merged commit 99b2eb1 into master Mar 24, 2017
@tisto tisto deleted the unittest2 branch March 24, 2017 12:20
@tisto tisto removed the in progress label Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasgraf lukasgraf lukasgraf approved these changes

@buchi buchi Awaiting requested review from buchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tisto @lukasgraf @coveralls