Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navigation and breadcrumbs as top-level services. #312

Merged
merged 5 commits into from
Jun 28, 2017
Merged

Add navigation and breadcrumbs as top-level services. #312

merged 5 commits into from
Jun 28, 2017

Conversation

tisto
Copy link
Sponsor Member

@tisto tisto commented Apr 17, 2017

No description provided.

@tisto
Copy link
Sponsor Member Author

tisto commented Apr 17, 2017

@jensens I would like to add deprecation messages when someone accesses the components which we are going to remove in future versions. I recall you looked into this a while ago. Would you mind providing me with some pointers what is considered best practice these days?

@coveralls
Copy link

coveralls commented Apr 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.268% when pulling 061a562 on remove-components into df94aa7 on master.

@coveralls
Copy link

coveralls commented Apr 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.268% when pulling 70481ec on remove-components into df94aa7 on master.

@tisto tisto mentioned this pull request Apr 17, 2017
Closed
19 tasks
@coveralls
Copy link

coveralls commented Apr 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.276% when pulling 8271e5e on remove-components into 3b2c9e9 on master.

@tisto tisto mentioned this pull request Apr 17, 2017
Closed
@tisto tisto added this to the 1.0a14 milestone Apr 18, 2017
@tisto tisto changed the title [WIP] Add navigation and breadcrumbs as top-level services. Add navigation and breadcrumbs as top-level services. Apr 29, 2017
@coveralls
Copy link

coveralls commented Apr 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 96.503% when pulling 026859e on remove-components into 3b2c9e9 on master.

@tisto tisto removed this from the 1.0a14 milestone Jun 26, 2017
@tisto tisto merged commit 7d9aa05 into master Jun 28, 2017
@tisto tisto deleted the remove-components branch June 28, 2017 17:19
@tisto tisto mentioned this pull request Jul 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tisto @coveralls