Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata fields in summaries #767

Merged
merged 4 commits into from Jun 30, 2019
Merged

Metadata fields in summaries #767

merged 4 commits into from Jun 30, 2019

Conversation

buchi
Copy link
Member

@buchi buchi commented Jun 22, 2019

Support retrieval of additional metadata fields in summaries in the same way as in search results.

Closes #681

@mister-roboto
Copy link

@buchi thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@buchi
Copy link
Member Author

buchi commented Jun 22, 2019

@jenkins-plone-org please run jobs

@coveralls
Copy link

coveralls commented Jun 22, 2019

Coverage Status

Coverage decreased (-0.01%) to 96.244% when pulling 4ab0e45 on metadata-fields-in-summaries into d6597a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.718% when pulling 2d788ea on metadata-fields-in-summaries into d57b8ef on master.

@buchi buchi force-pushed the metadata-fields-in-summaries branch from 2d788ea to 699e2d2 Compare June 22, 2019 15:01
@buchi
Copy link
Member Author

buchi commented Jun 22, 2019

@jenkins-plone-org please run jobs

Copy link
Member

@lukasgraf lukasgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Support retrieval of additional metadata fields in summaries in the same way as
in search results.
The summary serializer already does all the work.
@buchi buchi force-pushed the metadata-fields-in-summaries branch from 699e2d2 to 62a82fc Compare June 24, 2019 09:06
@buchi
Copy link
Member Author

buchi commented Jun 24, 2019

@jenkins-plone-org please run jobs

@buchi buchi force-pushed the metadata-fields-in-summaries branch from 62a82fc to 4ab0e45 Compare June 24, 2019 12:56
@buchi
Copy link
Member Author

buchi commented Jun 24, 2019

@jenkins-plone-org please run jobs

@tisto tisto merged commit 6fd5f89 into master Jun 30, 2019
@tisto tisto deleted the metadata-fields-in-summaries branch June 30, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No metadata fields with GET on a folderish resource
5 participants