Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plone 4.3.x build #858

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Fix Plone 4.3.x build #858

merged 1 commit into from
Jan 22, 2020

Conversation

lukasgraf
Copy link
Member

This adds version constraints to plone-4.3.x.cfg needed for Python 2.7 compatibility.

Fixes build failures like these:
https://travis-ci.org/plone/plone.restapi/jobs/640324488

@lukasgraf lukasgraf requested a review from tisto January 22, 2020 08:47
@mister-roboto

This comment has been minimized.

@lukasgraf
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside the fact that this is missing a changelog line (but that is going to be added in the follow up PR #859).
I would say merge it anyway

@lukasgraf
Copy link
Member Author

@ale-rt I deliberately left out the changelog since it doesn't contain any functional changes to the code. Quite the opposite, it would produce an entry that would just be distracting for someone combing through the CL to look for API changes. That's why we usually haven't added CL entries for these kinds of changes.

@tisto tisto merged commit 32a80ab into master Jan 22, 2020
@tisto tisto deleted the fix-plone43-build branch January 22, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants