Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Decimal fields while deserializing. #903

Merged
merged 13 commits into from
Mar 6, 2023
Merged

Support Decimal fields while deserializing. #903

merged 13 commits into from
Mar 6, 2023

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Apr 7, 2020

DX Decimal fields were not support until now.

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.067% when pulling 10af83f on dx-decimal-deserializer-support into 474aaa5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.067% when pulling 10af83f on dx-decimal-deserializer-support into 474aaa5 on master.

@netlify
Copy link

netlify bot commented May 12, 2022 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit bbc59d1
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/627cc997f8547e0008ea4a3c

@netlify
Copy link

netlify bot commented Mar 1, 2023 •
edited
Loading

✅ Deploy Preview for plone-restapi ready!

Name Link
🔨 Latest commit ada22e9
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6401d348facd090008d9a771
😎 Deploy Preview https://deploy-preview-903--plone-restapi.netlify.app/usage/serialization.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jensens jensens force-pushed the dx-decimal-deserializer-support branch from bb90663 to 80a5bdd Compare March 1, 2023 14:53
@jensens jensens marked this pull request as ready for review March 1, 2023 14:59
@jensens
Copy link
Sponsor Member Author

jensens commented Mar 1, 2023

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member Author

jensens commented Mar 1, 2023

@jenkins-plone-org please run jobs

@jensens jensens requested a review from tisto March 1, 2023 16:50
davisagli
davisagli reviewed Mar 2, 2023
View reviewed changes
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add docs about decimals to https://6.docs.plone.org/plone.restapi/docs/source/usage/serialization.html and mention that they should be represented as strings rather than floats.

news/903.bugfix Outdated Show resolved Hide resolved
@jensens @davisagli
Update news/903.bugfix
f4d6f45 
Co-authored-by: David Glick <david@glicksoftware.com>
@jensens
Copy link
Sponsor Member Author

jensens commented Mar 2, 2023

We should add docs about decimals to https://6.docs.plone.org/plone.restapi/docs/source/usage/serialization.html and mention that they should be represented as strings rather than floats.

Done

davisagli
davisagli approved these changes Mar 2, 2023
View reviewed changes
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion to make a sentence in the docs easier to read, otherwise lgtm

docs/source/usage/serialization.md Outdated Show resolved Hide resolved
@jensens @davisagli
Update docs/source/usage/serialization.md
ada22e9 
Co-authored-by: David Glick <david@glicksoftware.com>
@jensens
Copy link
Sponsor Member Author

jensens commented Mar 3, 2023

@jenkins-plone-org please run jobs

@mohammadtaranom

This comment was marked as off-topic.

Sign in to view
@jensens
Copy link
Sponsor Member Author

jensens commented Mar 6, 2023

Hello. Where can I download penetration testing tools?

This is OT here, esp on this thread. Go to https://community/plone/org for this kind of question.

@jensens jensens merged commit 31a18e1 into master Mar 6, 2023
@jensens jensens deleted the dx-decimal-deserializer-support branch March 6, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@tisto tisto Awaiting requested review from tisto

Assignees
No one assigned
Labels
04 type: enhancement 13 prio: normal 24 status: ready 32 needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jensens @mister-roboto @coveralls @mohammadtaranom @davisagli