Fixed test for 'Connection refused' which could be 'Connection reset'. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauritsvanrees thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
Either W503 will fail or W504. lint-py27 runtests: commands[2] | flake8 --doctests src tests setup.py src/plone/testing/layer.py:126:26: W504 line break after binary operator src/plone/testing/layer.py:127:74: W504 line break after binary operator setup.py:49:36: W504 line break after binary operator
It's strange. Without this, when I run flake8 I get this: $ .tox/lint-py27/bin/flake8 --doctests src tests setup.py src/plone/testing/layer.py:127:13: W503 line break before binary operator src/plone/testing/layer.py:128:13: W503 line break before binary operator setup.py:51:9: W503 line break before binary operator We should ignore W503, so I pass an extra option, and then I get different errors: $ .tox/lint-py27/bin/flake8 --doctests --ignore=W503 src tests setup.py src/plone/testing/zope.py:124:19: T000 Todo note found. src/plone/testing/tests.py:95:9: T003 use of Django-style assert statement found (instead of regular assert): assertIsNotNone
|
@jenkins-plone-org please run jobs |
|
Since Jenkins 5.2 is broken the entire day, and this fixes it, I merge it myself. All checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #59.