Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where it was not possibly to POST a query string value for a primary field #30

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

datakurre
Copy link
Member

Fixes issue where creating a Mosaic page with pre-defined content layout with pre-defined rich text fields ended up having empty rich text fields, because the field is marked primary (as it should be, for proper rich text marshaling), and primary fields were never parsed from query string by default.

@mister-roboto
Copy link

@datakurre thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@datakurre datakurre requested a review from MrTango April 16, 2019 08:42
@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage remained the same at 86.619% when pulling f5a1a91 on datakurre/fix-primary-field-from-query into a997241 on master.

@jensens
Copy link
Sponsor Member

jensens commented Apr 17, 2019

@jenkins-plone-org please run jobs

@jensens jensens merged commit a82d390 into master Apr 18, 2019
@jensens jensens deleted the datakurre/fix-primary-field-from-query branch April 18, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants