Fixed deprecation warning for ComponentLookupError. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@jenkins-plone-org please run jobs |
Traceback is slightly different than we expect on Plone 5.2:
```
File "/Users/maurits/community/plone-coredev/5.2/src/plone.tiles/plone/tiles/tests/../data.rst", line 112, in data.rst
Failed example:
encode(data, IUnsupported) # doctest: +ELLIPSIS
Expected:
Traceback (most recent call last):
...
zope.interface.interfaces.ComponentLookupError: Cannot URL encode decimal of type <class 'zope.schema._field.Decimal'>
Got:
Traceback (most recent call last):
File "/Users/maurits/.pyenv/versions/2.7.17/lib/python2.7/doctest.py", line 1315, in __run
compileflags, 1) in test.globs
File "<doctest data.rst[24]>", line 1, in <module>
encode(data, IUnsupported) # doctest: +ELLIPSIS
File "/Users/maurits/community/plone-coredev/5.2/src/plone.tiles/plone/tiles/data.py", line 285, in encode
field.__class__
ComponentLookupError: Cannot URL encode decimal of type <class 'zope.schema._bootstrapfields.Decimal'>
```
But for other versions it may be the same as always, so make the test less strict.
gforcada
approved these changes
Aug 27, 2020
|
I improved the existing doctest output checker. We could drop 4.3 support here as well, but it's okay for now. @jenkins-plone-org please run jobs |
No longer test this on Travis. The doctest output checking was getting a bit too crazy, and not working.
[ci skip]
|
I dropped 4.3 support. Actually, this is not tested on Jenkins, so we don't need to run the tests there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.