React 18.2.0 in Volto core - and all that fun #3221

sneridagh · 2022-04-02T14:37:57Z

It's time to update to latest ReactJS version. Since it's been around for 2.5 years already, and all indicates that the React Team could finally make the move with the release of 19 in the horizon.

This will allow to unify the React versions used across all the current projects.

I was forced to remove a couple of unit tests, that we might want to review at some point. However, one is irelevant, the other we can live without it, although it would be great to make it work at some point.

netlify · 2022-04-02T14:38:03Z

✅ Deploy Preview for volto ready!

Name	Link
🔨 Latest commit	`cfff829`
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/65e18df4aca9f200083b6779
😎 Deploy Preview	https://deploy-preview-3221--volto.netlify.app/upgrade-guide/index.html
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tiberiuichim · 2022-04-02T14:42:17Z

Looks like somebody's itching :)

* main: (1505 commits) Links references view cypress tests (#5111) Unify start command, trigger `build:deps` command too (#5633) Release generate-volto 9.0.0-alpha.3 Release @plone/types 1.0.0-alpha.2 Improve Blocks typings. Refactor `volto-coresandbox` to TS. (#5624) i18n polishing (#5542) Release @plone/scripts 3.2.1 Fix @plone/scripts for 17 and below (#5613) Release @plone/scripts 3.2.0 Enhance `ColorPickerWidget` (#5585) edit recurrence button is aligned properly (#5590) Revert "Attempt to build the volto/components Storybook only when something c…" (#5601) Revert "Added Storybook to Netlify build to allow relative links from documen…" (#5598) Added Storybook to Netlify build to allow relative links from documen… (#5596) Attempt to build the volto/components Storybook only when something c… (#5595) Pin mrs.developer to an updated version, never to star. (#5593) Allow to bail off the nested name build in the custom CSS properties style name generator (#5586) Clarify how CSS properties work (#5592) Release 18.0.0-alpha.6 Release @plone/client 1.0.0-alpha.12 ...

netlify · 2024-01-17T17:34:35Z

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	`cfff829`
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/65e18df4c7c04a000872c411

sneridagh · 2024-01-19T21:43:52Z

@tiberiuichim there's a last test that is failing. I thin you wrote it. I have no clue why it's failing, it seems fine from the user perspective, but the test says that inside the data structure is not ok. Could be a timing issue, difficult to figure out. Putting waits does not work :( Could you please take a look?

https://github.com/plone/volto/actions/runs/7588014835/job/20674005099#step:10:301

The idea is to upgrade to 18 in Volto 18... Makes sense especially after all these years. Then at least we are in the last React "stable" published.

* main: Block search engines from indexing content on Netlify preview builds (#5725) fixed a11y Logo Issue and added Translations (#5722) Allow editor to edit metadata name during bulk or single upload (#5560) 5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on (#5709) Remove turbo from monorepo commands until it's really necessary (#5715) bugfix: wrong conditional proprieties on ObjectBrowser (#4190) Added aria-live='polite' (#5639) Release 18.0.0-alpha.9 Release @plone/scripts 3.3.2 fix: handle addons that have not been migrated to the new structure o… (#5704) Update Semantic UI React to version 2.1.5 (#5632) Removed unmaintained and unused razzle-plugin-bundle-analyze (#5671) 3716 - improve validation of id widget (#4686) Fixed redirect of https://tanstack.com/query/v4/docs/react/guides/ssr… (#5700) Release 18.0.0-alpha.8 Release @plone/volto 18.0.0-alpha.7 (not pushed to main) Release @plone/slate 18.0.0-alpha.6 Release @plone/registry 1.2.1 (not pushed to repo)

* main: (43 commits) 5645 toolbar buttons toggle when clicking same toolbar button (#5795) fix: array widget sort (#5805) Fix a11y logo issue (#5776) Improve Vite PoC - Add BlockRenderer and `@plone/blocks` to the party (#5798) Removed memori websites that give 404 since they are no longer using Volto (#5803) Release Management Notes (#5358) Enhance findBlocks to check for blocks in data for add-ons (#5797) Release @plone/components 2.0.0-alpha.2 Move basic default CSS out of theme. Improve StoryBook intro page (#5791) Switch peerDependencies to Volto 18 for generator-volto alpha's/latest. (#5781) Release 18.0.0-alpha.13 Release @plone/slate 18.0.0-alpha.7 Fix sidebar form update. (#5779) Add uncommited types for release?? Release 18.0.0-alpha.12 Add accordion to metadata form. (#5760) Release @plone/registry 1.3.1 [registry] Export Config type as ConfigType, amend coresandbox (#5774) Release @plone/components 2.0.0-alpha.1 Add import path for compiled CSS (#5770) ...

sneridagh · 2024-02-29T12:51:02Z

GREEEEEEN!!!!

🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢

tiberiuichim

This is a major achievement, many many thanks for this work!

sneridagh · 2024-02-29T13:11:58Z

@stevepiercy some docs, please review!

stevepiercy

Minor tweaks on docs.

docs/source/upgrade-guide/index.md

ichim-david

@sneridagh I would of expected more work besides the portal replacement and isClient and the test changes for slate, this is awesome, thank you as well.

packages/volto/src/components/manage/Form/Form.jsx

packages/volto/src/helpers/Utils/usePagination.test.js.removed

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Co-authored-by: ichim-david <ichim.david@gmail.com>

sneridagh · 2024-02-29T14:32:09Z

I would of expected more work besides the portal replacement and isClient and the test changes for slate, this is awesome, thank you as well.

This one was not easy, I tell you. Sweating blood in buckets at some moments, but it's done.

davisagli

@sneridagh I few very minor comments, but basically looks good.

packages/registry/news/3221.feature

packages/volto/src/components/manage/Blocks/Block/BlocksForm.jsx

packages/volto/src/helpers/Utils/usePagination.test.js.removed

* main: Slots in core (#5775)

* main: Release 18.0.0-alpha.14 Fix types for latest build, check if CI is happy (#5814) Release generate-volto 9.0.0-alpha.7 Release @plone/types 1.0.0-alpha.4 Release @plone/registry 1.4.0 Release @plone/components 2.0.0-alpha.3

WIP

191ae38

sneridagh marked this pull request as draft April 2, 2022 14:38

Upgrade testing packages

1239b6d

tiberiuichim added the proof of concept A proof of concept, ready to lead to something great! label Nov 25, 2022

sneridagh mentioned this pull request Jan 17, 2024

Upgrade to React 18 #5641

Closed

2 tasks

sneridagh added 2 commits January 17, 2024 09:05

Update deps

dbdec2e

sneridagh force-pushed the react18 branch from 34e38a1 to dbdec2e Compare January 17, 2024 17:34

sneridagh added 3 commits January 17, 2024 18:35

Merge branch 'main' into react18

cd3ea48

Fix hydration errors

414cd5e

Fix listings and objectbrowser

316cadc

sneridagh added 10 commits January 22, 2024 09:14

Fix some unit tests relative to snapshots

a67c68a

Merge branch 'main' into react18

9fe05d0

Merge branch 'main' into react18

38af96e

Fix unit tests :)

3871c96

Fix linting

29f15dc

Force acceptance videos on seamless

7886ebd

Changelog

83f7973

Changelog

5883090

folder contents flaky test

9b23a93

sneridagh removed the proof of concept A proof of concept, ready to lead to something great! label Feb 1, 2024

sneridagh added this to the 18.x.x milestone Feb 1, 2024

sneridagh added 3 commits February 1, 2024 22:43

Upgrade Cypress

d1e385e

Update actions

f5e424d

Problems with keys and the sidebar

7eed755

sneridagh added 10 commits February 5, 2024 14:17

Merge branch 'main' into react18

33f71e4

Merge branch 'main' into react18

e3688a2

Remove react-portal library

06563d2

Fix unit tests

9235ae2

Adjustments to the last commits

f86866c

Fix slate insert break order T_T

acdc788

Add guard

1a2918f

Fix unit

2af33b4

Fix last slate Cypress fail

c582221

sneridagh requested a review from a team February 29, 2024 12:50

tiberiuichim approved these changes Feb 29, 2024

View reviewed changes

Add upgrade guide docs

6eb98f7

stevepiercy requested changes Feb 29, 2024

View reviewed changes

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

ichim-david approved these changes Feb 29, 2024

View reviewed changes

packages/volto/src/components/manage/Form/Form.jsx Outdated Show resolved Hide resolved

packages/volto/src/helpers/Utils/usePagination.test.js.removed Outdated Show resolved Hide resolved

sneridagh and others added 2 commits February 29, 2024 15:30

Apply suggestions from code review

398a82c

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Update packages/volto/src/components/manage/Form/Form.jsx

bc190d7

Co-authored-by: ichim-david <ichim.david@gmail.com>

Merge branch 'main' into react18

857e990

pnicolli approved these changes Feb 29, 2024

View reviewed changes

davisagli approved these changes Feb 29, 2024

View reviewed changes

packages/registry/news/3221.feature Outdated Show resolved Hide resolved

packages/volto/src/components/manage/Blocks/Block/BlocksForm.jsx Outdated Show resolved Hide resolved

packages/volto/src/helpers/Utils/usePagination.test.js.removed Outdated Show resolved Hide resolved

sneridagh added 4 commits February 29, 2024 23:22

Merge branch 'main' into react18

4e85cca

* main: Slots in core (#5775)

Fix tests

51201ae

David's suggestions

8614e40

Merge branch 'main' into react18

cfff829

* main: Release 18.0.0-alpha.14 Fix types for latest build, check if CI is happy (#5814) Release generate-volto 9.0.0-alpha.7 Release @plone/types 1.0.0-alpha.4 Release @plone/registry 1.4.0 Release @plone/components 2.0.0-alpha.3

sneridagh merged commit 70ed657 into main Mar 1, 2024
33 checks passed

sneridagh deleted the react18 branch March 1, 2024 08:29

sneridagh linked an issue Mar 4, 2024 that may be closed by this pull request

Upgrade to React 18 #5641

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React 18.2.0 in Volto core - and all that fun #3221

React 18.2.0 in Volto core - and all that fun #3221

sneridagh commented Apr 2, 2022 •

edited

netlify bot commented Apr 2, 2022 •

edited

tiberiuichim commented Apr 2, 2022

netlify bot commented Jan 17, 2024 •

edited

sneridagh commented Jan 19, 2024 •

edited

sneridagh commented Feb 29, 2024

tiberiuichim left a comment

sneridagh commented Feb 29, 2024

stevepiercy left a comment

ichim-david left a comment

sneridagh commented Feb 29, 2024

davisagli left a comment

React 18.2.0 in Volto core - and all that fun #3221

React 18.2.0 in Volto core - and all that fun #3221

Conversation

sneridagh commented Apr 2, 2022 • edited

netlify bot commented Apr 2, 2022 • edited

✅ Deploy Preview for volto ready!

tiberiuichim commented Apr 2, 2022

netlify bot commented Jan 17, 2024 • edited

✅ Deploy Preview for plone-components canceled.

sneridagh commented Jan 19, 2024 • edited

sneridagh commented Feb 29, 2024

tiberiuichim left a comment

Choose a reason for hiding this comment

sneridagh commented Feb 29, 2024

stevepiercy left a comment

Choose a reason for hiding this comment

ichim-david left a comment

Choose a reason for hiding this comment

sneridagh commented Feb 29, 2024

davisagli left a comment

Choose a reason for hiding this comment

sneridagh commented Apr 2, 2022 •

edited

netlify bot commented Apr 2, 2022 •

edited

netlify bot commented Jan 17, 2024 •

edited

sneridagh commented Jan 19, 2024 •

edited