Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnD shanenigan in the DraggableOverlay (grey droppable position area) in horizontal lists #4405

Open
sneridagh opened this issue Feb 17, 2023 · 1 comment
Assignees

Comments

@sneridagh
Copy link
Member

sneridagh commented Feb 17, 2023

Describe the bug
When using the DragDropList component in a horizontal list (eg. new rowblock PR: #3180), the grey area that indicates where the element is going to be dropped is wrong (as it only expects vertical lists).

To Reproduce
In the rowblock PR: #3180

  1. Add a new page
  2. Create a Row block with 2 elements
  3. Try to move one, and derive a bit on top or bottom
  4. See a "ghost" grey box down the block
Screen.Recording.2023-02-17.at.15.32.22.mov

Expected behavior
The box is rendered in the horizontal list as well, in the correct positions.

Additional context
In the rowblock PR I've overcome it by detecting the direction. To test it properly, one has to remove:

149be8c#diff-6bdca3d9027d170f430a5a10ac07aedf0e02571ae2b217646e11745da0b24d84L143-R158

{direction !== 'horizontal' &&
@sneridagh
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants